VerifyMe - Code Metrics - bytesfield/sabi-customer - Measure and Improve Code Quality continuously with Scrutinizer

VerifyMe A
last analyzed 2021-06-09 21:25 UTC

↳ Parent: src/pipes/VerifyMe.js

Complexity

Total Complexity

Size/Duplication

Total Lines	99
Duplicated Lines	0 %

Importance

Changes

Metric	Value
eloc	47
dl	0
loc	99
rs	10
c	0
b	0
f	0
wmc	10

4 Functions

Rating	Name	Size	Complexity
A	getType	16	5
A	constructor	6	1
A	process	6	1
A	handle	46	3

const httpProcessor = require('../HttpProcessor');
const services = require('../config/services');
const constants = require('../config/constants');

class VerifyMe
{
    constructor() {
        this.client = services.verifyMe.client;
        this.apiKey = services.verifyMe.api_key;
        this.baseUrl = services.verifyMe.api_url;

    }

    /**
    * Process axios calls
    * 
    * @param {string} method The call method get|post|put|delete|patch
    * @param {string} url The url to call
    * @param {object|formData} payload The payload data to send with the call
    */
    process(method, url, payload) {
        //HttpProcessor class to handle axios calls
        let processor = new httpProcessor(this.baseUrl, this.apiKey, this.client);


        return processor.process(method, url, payload)
    }

    /**
    * Handles the ID request
    *
    * @param {object} IdFilter
    * @return {object}
    */
    async handle(IdFilter)
    {
        if (!IdFilter.isSuccessful()) {
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
            const idType = IdFilter.getIDType().toUpperCase();
            const type = this.getType(idType);
            const idNumber =  IdFilter.getIDNumber();

            const url = '/v1/verifications/identities/' + type + '/:' + idNumber;

            const firstName =  IdFilter.getFirstName();
            const lastName =  IdFilter.getLastName();
            const dateOfBirth =  IdFilter.getDOB();

            const body = {
                'id' : idNumber,
                'firstname' : firstName,
                'lastname' : lastName,
                'dob' : dateOfBirth,
            };

            try {
                const response = await this.process('POST', url, body);

                IdFilter.confirmSuccess();

                IdFilter.setHandler(this.client);

                IdFilter.setData({
                    'handler' : IdFilter.getHandler(),
                    'country' : 'NG',
                    'message' : idType + ' Verified' + ' Successfully',
                    'data' : response
                });
                
                return IdFilter.getData();
                
            } catch (error) {
                //Error occurred
                IdFilter.setError({'error' : error});
                
                console.log(error);

                return IdFilter.getError();
            }
        }

    }

    /**
    * Transform the ID
    *
    * @param {string} type
    * @return {string}
    */
    getType(type)
    {
        if (type === constants.idValues.TYPE_DRIVERS_LICENSE) {
            return 'drivers_license';
        }
        if (type === constants.idValues.TYPE_NIN ) {
            return 'nin';
        }
        if (type === constants.idValues.TYPE_VOTER_CARD) {
            return 'vin';
        }
        if (type === constants.idValues.TYPE_BVN) {
            return 'bvn';
        }
        return type.toLowerCase();
    }
}

module.exports = VerifyMe;

1			const httpProcessor = require('../HttpProcessor');
2			const services = require('../config/services');
3			const constants = require('../config/constants');
4
5			class VerifyMe
6			{
7			constructor() {
8			this.client = services.verifyMe.client;
9			this.apiKey = services.verifyMe.api_key;
10			this.baseUrl = services.verifyMe.api_url;
11
12			}
13
14			/**
15			* Process axios calls
16			*
17			* @param {string} method The call method get\|post\|put\|delete\|patch
18			* @param {string} url The url to call
19			* @param {object\|formData} payload The payload data to send with the call
20			*/
21			process(method, url, payload) {
22			//HttpProcessor class to handle axios calls
23			let processor = new httpProcessor(this.baseUrl, this.apiKey, this.client);
			0 ignored issues – show Coding Style Best Practice introduced 2021-06-09 20:56 UTC by Report Bug Copy Issue Report By convention, constructors like `httpProcessor` should be capitalized. Loading history...
24
25			return processor.process(method, url, payload)
26			}
27
28			/**
29			* Handles the ID request
30			*
31			* @param {object} IdFilter
32			* @return {object}
33			*/
34			async handle(IdFilter)
35			{
36			if (!IdFilter.isSuccessful()) {
			0 ignored issues – show Complexity Best Practice introduced 2021-06-09 20:56 UTC by Report Bug Copy Issue Report There is no return statement if `!IdFilter.isSuccessful()` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
37			const idType = IdFilter.getIDType().toUpperCase();
38			const type = this.getType(idType);
39			const idNumber = IdFilter.getIDNumber();
40
41			const url = '/v1/verifications/identities/' + type + '/:' + idNumber;
42
43			const firstName = IdFilter.getFirstName();
44			const lastName = IdFilter.getLastName();
45			const dateOfBirth = IdFilter.getDOB();
46
47			const body = {
48			'id' : idNumber,
49			'firstname' : firstName,
50			'lastname' : lastName,
51			'dob' : dateOfBirth,
52			};
53
54			try {
55			const response = await this.process('POST', url, body);
56
57			IdFilter.confirmSuccess();
58
59			IdFilter.setHandler(this.client);
60
61			IdFilter.setData({
62			'handler' : IdFilter.getHandler(),
63			'country' : 'NG',
64			'message' : idType + ' Verified' + ' Successfully',
65			'data' : response
66			});
67
68			return IdFilter.getData();
69
70			} catch (error) {
71			//Error occurred
72			IdFilter.setError({'error' : error});
73
74			console.log(error);
			0 ignored issues – show Debugging Code introduced 2021-06-09 20:56 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
75			return IdFilter.getError();
76			}
77			}
78
79			}
80
81			/**
82			* Transform the ID
83			*
84			* @param {string} type
85			* @return {string}
86			*/
87			getType(type)
88			{
89			if (type === constants.idValues.TYPE_DRIVERS_LICENSE) {
90			return 'drivers_license';
91			}
92			if (type === constants.idValues.TYPE_NIN ) {
93			return 'nin';
94			}
95			if (type === constants.idValues.TYPE_VOTER_CARD) {
96			return 'vin';
97			}
98			if (type === constants.idValues.TYPE_BVN) {
99			return 'bvn';
100			}
101			return type.toLowerCase();
102			}
103			}
104
105			module.exports = VerifyMe;

bytesfield / sabi-customer

VerifyMe A last analyzed 2021-06-09 21:25 UTC

Complexity

Size/Duplication

Importance

4 Functions

Duplication Side-by-Side

Filter issues like

VerifyMe A
last analyzed 2021-06-09 21:25 UTC